Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SetDebugMode by a more flexible ExternalLogger functionality #1069

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mariomac
Copy link
Contributor

This would facilitate integrating Beyla with Alloy's logger configuration.

@mariomac mariomac requested a review from rafaelroquetto July 30, 2024 07:39
@mariomac mariomac marked this pull request as ready for review July 30, 2024 07:39
@mariomac mariomac requested review from grcevski and marctc as code owners July 30, 2024 07:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (7e6c73d) to head (9565d03).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
+ Coverage   81.76%   81.84%   +0.08%     
==========================================
  Files         139      139              
  Lines       11317    11314       -3     
==========================================
+ Hits         9253     9260       +7     
+ Misses       1545     1536       -9     
+ Partials      519      518       -1     
Flag Coverage Δ
integration-test 56.88% <0.00%> (-0.07%) ⬇️
k8s-integration-test 59.30% <0.00%> (+0.07%) ⬆️
oats-test 36.96% <0.00%> (+<0.01%) ⬆️
unittests 51.94% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 9d07bfb into grafana:main Jul 30, 2024
6 checks passed
@mariomac mariomac deleted the set-external-log branch July 30, 2024 09:05
Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants