Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OTEL expirer and hide it from docs #1066

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mariomac
Copy link
Contributor

Provides a workaround for #1065 until we manage to fix the OTEL code.

@mariomac mariomac marked this pull request as ready for review July 26, 2024 15:44
@mariomac mariomac requested review from grcevski and marctc as code owners July 26, 2024 15:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (1f8435d) to head (dc05e01).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   79.20%   81.91%   +2.71%     
==========================================
  Files         139      139              
  Lines       11328    11328              
==========================================
+ Hits         8972     9279     +307     
+ Misses       1812     1532     -280     
+ Partials      544      517      -27     
Flag Coverage Δ
integration-test 56.81% <ø> (?)
k8s-integration-test 59.13% <ø> (ø)
oats-test 36.92% <ø> (+<0.01%) ⬆️
unittests 52.02% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 1cf4f86 into grafana:main Jul 29, 2024
8 checks passed
@mariomac mariomac deleted the disable-otel-expire branch July 29, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants