Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count testing in OTEL histogram export #1064

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

mariomac
Copy link
Contributor

Doesn't really fix anything, just provides extra safety to histogram unit tests.

@mariomac mariomac marked this pull request as ready for review July 26, 2024 14:45
@mariomac mariomac requested review from grcevski and marctc as code owners July 26, 2024 14:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (156e6dd) to head (6f28e66).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   78.77%   81.88%   +3.10%     
==========================================
  Files         139      139              
  Lines       11328    11328              
==========================================
+ Hits         8924     9276     +352     
+ Misses       1882     1534     -348     
+ Partials      522      518       -4     
Flag Coverage Δ
integration-test 56.81% <ø> (+0.07%) ⬆️
k8s-integration-test 59.13% <ø> (-0.01%) ⬇️
oats-test 36.92% <ø> (?)
unittests 52.08% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 07b47e8 into grafana:main Jul 29, 2024
6 checks passed
@mariomac mariomac deleted the count-test branch July 29, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants