Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire span metrics and service graph metrics in the OTEL exporter #1062

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

mariomac
Copy link
Contributor

The traces_target_info case is a bit more complex case and will be expired in another PR, just to keep this PR small.

@mariomac mariomac marked this pull request as ready for review July 26, 2024 10:56
@mariomac mariomac requested review from grcevski and marctc as code owners July 26, 2024 10:56
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 91.72932% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (09c206f) to head (faad757).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/export/otel/metrics.go 93.54% 4 Missing ⚠️
pkg/internal/request/span_getters.go 84.61% 2 Missing and 2 partials ⚠️
pkg/internal/request/span.go 92.85% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   79.09%   81.86%   +2.76%     
==========================================
  Files         139      139              
  Lines       11289    11320      +31     
==========================================
+ Hits         8929     9267     +338     
+ Misses       1818     1534     -284     
+ Partials      542      519      -23     
Flag Coverage Δ
integration-test 56.85% <53.38%> (?)
k8s-integration-test 59.07% <75.93%> (+0.08%) ⬆️
oats-test 36.94% <16.54%> (-0.11%) ⬇️
unittests 51.92% <27.06%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few side-comments/ideas. I will leave it for the experts to approve :)

pkg/internal/request/metric_attributes.go Outdated Show resolved Hide resolved
pkg/internal/request/metric_attributes.go Outdated Show resolved Hide resolved
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing, thanks!

@mariomac mariomac merged commit 156e6dd into grafana:main Jul 26, 2024
6 checks passed
@mariomac mariomac deleted the expire-sg branch July 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants