Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues for Alloy integration #1058

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Fix some issues for Alloy integration #1058

merged 3 commits into from
Jul 26, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 25, 2024

This PR fixes some issues that makes integration with Alloy possible:

  • Downgrade OTEL to v0.102.1
  • Avoid duplicated registration of beyla_build_info metric.
  • Add extra condition in Enabled function for process metrics.
  • Fix SetDebugMode to effectively enable debug logger.

@marctc marctc requested review from grcevski and mariomac as code owners July 25, 2024 15:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.71%. Comparing base (ada2a72) to head (0e83618).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
pkg/beyla/config.go 0.00% 5 Missing ⚠️
pkg/internal/imetrics/iprom.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   81.75%   81.71%   -0.05%     
==========================================
  Files         139      139              
  Lines       11297    11302       +5     
==========================================
- Hits         9236     9235       -1     
- Misses       1543     1548       +5     
- Partials      518      519       +1     
Flag Coverage Δ
integration-test 56.73% <41.66%> (+<0.01%) ⬆️
k8s-integration-test 58.87% <41.66%> (-0.07%) ⬇️
oats-test 37.00% <16.66%> (-0.02%) ⬇️
unittests 52.22% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marctc marctc merged commit 5eb321c into main Jul 26, 2024
6 checks passed
@marctc marctc deleted the fix_stuff_alloy branch July 26, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants