Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent beyla self-instrumentation #1048

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

grcevski
Copy link
Contributor

Depending on how customers choose to deploy beyla, we can easily end up in a situation where Beyla is self-instrumenting itself. One example would be setting "all" for an executable name or a kubernetes pod/service/namespace. This is particularly common actually, because our default helm configuration instruments all namespaces, so Beyla will self-instrument even when it's installed in its own namespace.

Self-instrumentation comes with serious consequences, mainly because of self-perpetuating instrumentation of calls to /v1/metrics and /v1/traces. This creates unnecessary load on all components in the system and drowns the collection pipeline.

I've added an option to purposefully enable Beyla self-instrumentation, however I think we shouldn't even document it. It should be purely internal option we may choose to enable in some special circumstances.

@grcevski grcevski requested review from mariomac and marctc as code owners July 22, 2024 22:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (f9a8d4b) to head (f245fec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   81.50%   81.50%   -0.01%     
==========================================
  Files         139      139              
  Lines       11113    11119       +6     
==========================================
+ Hits         9058     9062       +4     
  Misses       1543     1543              
- Partials      512      514       +2     
Flag Coverage Δ
integration-test 56.91% <100.00%> (+0.04%) ⬆️
k8s-integration-test 58.93% <50.00%> (-0.11%) ⬇️
oats-test 37.42% <50.00%> (+<0.01%) ⬆️
unittests 50.99% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature!

@grcevski grcevski merged commit 437e171 into grafana:main Jul 23, 2024
6 checks passed
@grcevski grcevski deleted the disable_beyla_instr branch July 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants