Prevent beyla self-instrumentation #1048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how customers choose to deploy beyla, we can easily end up in a situation where Beyla is self-instrumenting itself. One example would be setting "all" for an executable name or a kubernetes pod/service/namespace. This is particularly common actually, because our default helm configuration instruments all namespaces, so Beyla will self-instrument even when it's installed in its own namespace.
Self-instrumentation comes with serious consequences, mainly because of self-perpetuating instrumentation of calls to /v1/metrics and /v1/traces. This creates unnecessary load on all components in the system and drowns the collection pipeline.
I've added an option to purposefully enable Beyla self-instrumentation, however I think we shouldn't even document it. It should be purely internal option we may choose to enable in some special circumstances.