Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export k8s flags #1038

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Export k8s flags #1038

merged 2 commits into from
Jul 18, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 18, 2024

This PR moves kubernetes flags to its own exported package.
This is necessary for alloy to enable or disable k8s monitoring.

@marctc marctc requested review from grcevski and mariomac as code owners July 18, 2024 12:19
@marctc marctc added the 1.9.0 label Jul 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (61c142d) to head (058afb1).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/kube/informer_provider.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1038   +/-   ##
=======================================
  Coverage   81.44%   81.44%           
=======================================
  Files         137      137           
  Lines       10962    10962           
=======================================
  Hits         8928     8928           
- Misses       1519     1520    +1     
+ Partials      515      514    -1     
Flag Coverage Δ
integration-test 56.17% <28.57%> (-0.06%) ⬇️
k8s-integration-test 58.95% <57.14%> (+0.02%) ⬆️
oats-test 37.22% <28.57%> (ø)
unittests 50.93% <28.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc merged commit 806a68a into main Jul 18, 2024
6 checks passed
@marctc marctc deleted the export_k8s_flags branch July 18, 2024 13:03
@marctc marctc removed the 1.9.0 label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants