Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetDebugMode function in config.go #1037

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add SetDebugMode function in config.go #1037

merged 2 commits into from
Jul 18, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 18, 2024

If we want to configure all debug capabilities for Beyla in places like
Alloy we would need to expose the whole eBPF config block to be public.
For now that seems not very necessary so this public method will allow
Alloy receive all debugging logs from Beyla.

@marctc marctc requested review from grcevski and mariomac as code owners July 18, 2024 08:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.39%. Comparing base (b28b9e1) to head (1222d19).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/beyla/config.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   81.66%   81.39%   -0.28%     
==========================================
  Files         137      137              
  Lines       10923    10962      +39     
==========================================
+ Hits         8920     8922       +2     
- Misses       1496     1523      +27     
- Partials      507      517      +10     
Flag Coverage Δ
integration-test 56.17% <0.00%> (-0.22%) ⬇️
k8s-integration-test 58.86% <0.00%> (-0.22%) ⬇️
oats-test 37.22% <0.00%> (-0.12%) ⬇️
unittests 50.91% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd also consider:

c.NetworkFlows.Print = true

@marctc marctc merged commit 61c142d into main Jul 18, 2024
6 checks passed
@marctc marctc deleted the debug_mode branch July 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants