-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More fixes for Go connection fetching #1036
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 81.46% 76.94% -4.52%
==========================================
Files 138 138
Lines 10988 11023 +35
==========================================
- Hits 8951 8482 -469
- Misses 1521 2021 +500
- Partials 516 520 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (once the failing tests are fixed)
🚀
There are two problems with our connection fetching code for Go:
TODO:
Make a test based on ServeHTTP for gRPC(I'll follow-up on this in another PR, since I have to fix HTTP2 status parsing too)