Use Prometheus registry when specified #1034
Conversation
pkg/components/beyla.go
Outdated
| @@ -114,9 +114,9 @@ func buildCommonContextInfo( | |||
| config.Attributes.Kubernetes.InformersSyncTimeout, | |||
| ), | |||
| } | |||
| if config.InternalMetrics.Prometheus.Port != 0 { | |||
| if config.InternalMetrics.Prometheus.Port != 0 || config.Prometheus.Registry != nil { | |||
There was a problem hiding this comment.
This would enable internal metrics by default when using Alloy. Any opinions against it?
There was a problem hiding this comment.
My only concern is open port for a container which is running with elevated permissions. It could increase the attack surface by default.
pkg/components/beyla.go
Outdated
| @@ -114,9 +114,9 @@ func buildCommonContextInfo( | |||
| config.Attributes.Kubernetes.InformersSyncTimeout, | |||
| ), | |||
| } | |||
| if config.InternalMetrics.Prometheus.Port != 0 { | |||
| if config.InternalMetrics.Prometheus.Port != 0 || config.Prometheus.Registry != nil { | |||
There was a problem hiding this comment.
My only concern is open port for a container which is running with elevated permissions. It could increase the attack surface by default.
marctc
force-pushed
the
prometheus_registry
branch
from
e4fa1ca to
7fba337
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 81.66% 81.46% -0.21%
==========================================
Files 137 137
Lines 10923 10956 +33
==========================================
+ Hits 8920 8925 +5
- Misses 1496 1515 +19
- Partials 507 516 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR enables using the Prometheus Registry (for Alloy) for the following metrics: