Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move export package from internal to pkg #1033

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 17, 2024

For Alloy component, we need to have access to access to tracing config
and Prometheus config. This PR moves packages from internal to pkg (public).

PR should be no-op.

@marctc marctc requested review from grcevski and mariomac as code owners July 17, 2024 15:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (1731edb) to head (0364c80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   79.06%   81.79%   +2.72%     
==========================================
  Files         137      137              
  Lines       10923    10923              
==========================================
+ Hits         8636     8934     +298     
+ Misses       1761     1488     -273     
+ Partials      526      501      -25     
Flag Coverage Δ
integration-test 56.45% <ø> (?)
k8s-integration-test 59.12% <ø> (+0.07%) ⬆️
oats-test 37.33% <ø> (ø)
unittests 51.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marctc marctc merged commit b28b9e1 into main Jul 18, 2024
6 checks passed
@marctc marctc deleted the make_export_package_public branch July 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants