Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: enumerate client/server port and process metrics #1020

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mariomac
Copy link
Contributor

No description provided.

@mariomac mariomac added the documentation Improvements or additions to documentation label Jul 16, 2024
@mariomac mariomac requested a review from grafsean July 16, 2024 10:36
@mariomac mariomac requested review from grcevski and marctc as code owners July 16, 2024 10:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.66%. Comparing base (84148fe) to head (c44848c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   81.64%   81.66%   +0.01%     
==========================================
  Files         137      137              
  Lines       10936    10936              
==========================================
+ Hits         8929     8931       +2     
+ Misses       1498     1497       -1     
+ Partials      509      508       -1     
Flag Coverage Δ
integration-test 56.42% <ø> (ø)
k8s-integration-test 59.01% <ø> (ø)
oats-test 37.40% <ø> (ø)
unittests 51.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@grafsean grafsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mariomac mariomac merged commit 463ad08 into grafana:main Jul 17, 2024
9 checks passed
@mariomac mariomac deleted the update-doc branch July 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants