Network metrics: report client and server port #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
- Coverage 80.30% 76.41% -3.90%
==========================================
Files 137 137
Lines 10953 10980 +27
==========================================
- Hits 8796 8390 -406
- Misses 1675 2081 +406
- Partials 482 509 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
commented
Jul 15, 2024
| @@ -89,7 +89,7 @@ spec: | |||
| - name: BEYLA_NETWORK_METRICS | |||
| value: "true" | |||
| - name: BEYLA_NETWORK_SOURCE | |||
| value: "socket_filter" | |||
| value: "tc" | |||
There was a problem hiding this comment.
Socket filter is now the default source, so we didn't have TC tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For network metrics, this patch tracks which IP:port initiated the connection, then Beyla is able to reconstruct the newly added
client_portandserver_portmetric attributes.