Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid un-understandable Pipes panics #1012

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

mariomac
Copy link
Contributor

Fixes #926 by providing understandable warning messages

@mariomac mariomac marked this pull request as ready for review July 12, 2024 14:05
@mariomac mariomac requested review from grcevski and marctc as code owners July 12, 2024 14:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (0c7d38f) to head (e47a9e9).

Files Patch % Lines
pkg/components/beyla.go 85.29% 4 Missing and 1 partial ⚠️
cmd/beyla/main.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   80.17%   80.55%   +0.38%     
==========================================
  Files         137      137              
  Lines       10930    10951      +21     
==========================================
+ Hits         8763     8822      +59     
+ Misses       1685     1646      -39     
- Partials      482      483       +1     
Flag Coverage Δ
integration-test 56.39% <40.54%> (+1.24%) ⬆️
k8s-integration-test 57.61% <40.54%> (-0.12%) ⬇️
oats-test 37.26% <18.91%> (-0.06%) ⬇️
unittests 50.80% <70.27%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac added the bug label Jul 12, 2024
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow awesome! LGTM!

@mariomac mariomac merged commit 877ecf8 into grafana:main Jul 15, 2024
7 checks passed
@mariomac mariomac deleted the fix-926 branch July 15, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beyla crashes if application metrics are disabled but BEYLA_OTEL_METRICS_FEATURES is explicitly defined
3 participants