Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we have enough access for span metrics #1010

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

grcevski
Copy link
Contributor

We now fetch the service names in app observability too. Make the permissions the same for neto11y and appo11y.

@grcevski grcevski requested review from mariomac and marctc as code owners July 11, 2024 21:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (890ebbf) to head (80194c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   81.19%   80.20%   -1.00%     
==========================================
  Files         137      137              
  Lines       10930    10930              
==========================================
- Hits         8875     8766     -109     
- Misses       1548     1684     +136     
+ Partials      507      480      -27     
Flag Coverage Δ
integration-test 55.01% <ø> (-1.02%) ⬇️
k8s-integration-test 57.77% <ø> (-0.91%) ⬇️
oats-test 37.31% <ø> (-0.02%) ⬇️
unittests 50.04% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@grcevski grcevski merged commit 1d2b480 into grafana:main Jul 12, 2024
6 checks passed
@grcevski grcevski deleted the helm_improvements branch July 12, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants