Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default network mode to socket filter to avoid cilium conflict #1008

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

grcevski
Copy link
Contributor

Changes the default from TC to socket filter.

@grcevski grcevski requested review from mariomac and marctc as code owners July 11, 2024 14:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.18%. Comparing base (890ebbf) to head (ac0cf73).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   81.19%   80.18%   -1.02%     
==========================================
  Files         137      137              
  Lines       10930    10930              
==========================================
- Hits         8875     8764     -111     
- Misses       1548     1685     +137     
+ Partials      507      481      -26     
Flag Coverage Δ
integration-test 55.05% <ø> (-0.98%) ⬇️
k8s-integration-test 57.63% <ø> (-1.06%) ⬇️
oats-test 37.31% <ø> (-0.02%) ⬇️
unittests 50.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 0c7d38f into grafana:main Jul 11, 2024
8 checks passed
@grcevski grcevski deleted the switch_network_mode branch July 11, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants