Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude src_port from kubernetes neto11y tests #1002

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jul 9, 2024

Some tests expecting to have 1 item after querying net o11y metrics are flaky because prometheus sometimes returns two metrics, due to the duplicity of src_port labels (two requests without reusing the connection).

@mariomac mariomac marked this pull request as ready for review July 9, 2024 09:41
@mariomac mariomac requested review from grcevski and marctc as code owners July 9, 2024 09:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (31390b2) to head (4007909).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   76.01%   81.04%   +5.03%     
==========================================
  Files         136      136              
  Lines       10805    10805              
==========================================
+ Hits         8213     8757     +544     
+ Misses       2084     1541     -543     
+ Partials      508      507       -1     
Flag Coverage Δ
integration-test 56.11% <ø> (+0.05%) ⬆️
k8s-integration-test 59.07% <ø> (?)
oats-test 36.09% <ø> (ø)
unittests 50.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mariomac mariomac merged commit 683b97e into grafana:main Jul 9, 2024
6 checks passed
@mariomac mariomac deleted the fix-kube-tests branch July 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants