Prevent negative network tx/rx data for process (#1123)

grafana · Sep 2, 2024 · 9a20dda · 9a20dda
1 parent b71dc56
commit 9a20dda
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/pkg/internal/infraolly/process/harvest.go b/pkg/internal/infraolly/process/harvest.go
@@ -201,8 +201,15 @@ func (ps *Harvester) populateNetworkInfo(status *Status, source *linuxProcess) {
 		return
 	}
 	rx, tx := parseProcNetDev(content)
-	status.NetRcvBytesDelta = rx - source.previousNetRx
-	status.NetTxBytesDelta = tx - source.previousNetTx
+	// removing a row in the /proc/<pid>/net/dev table could cause a negative delta
+	// and crashing the counters in the instrumentation libraries
+	if rx <= source.previousNetRx || tx <= source.previousNetTx {
+		status.NetRcvBytesDelta = 0
+		status.NetTxBytesDelta = 0
+	} else {
+		status.NetRcvBytesDelta = rx - source.previousNetRx
+		status.NetTxBytesDelta = tx - source.previousNetTx
+	}
 	source.previousNetRx = rx
 	source.previousNetTx = tx
 }