Skip to content

Commit

Permalink
Always decorate k8s_owner_name
Browse files Browse the repository at this point in the history
  • Loading branch information
@mariomac
mariomac committed Oct 4, 2024
1 parent 86c0519 commit 7ae8fc1
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 10 deletions.
21 changes: 11 additions & 10 deletions docs/sources/metrics.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,17 @@ In order to configure which attributes to show or which attributes to hide, chec
| Application (all) | `http.request.method` | shown |
| Application (all) | `http.response.status_code` | shown |
| Application (all) | `http.route` | shown if `routes` configuration section exists |
| Application (all) | `k8s.daemonset.name` | shown if network metrics are enabled |
| Application (all) | `k8s.deployment.name` | shown if network metrics are enabled |
| Application (all) | `k8s.namespace.name` | shown if network metrics are enabled |
| Application (all) | `k8s.node.name` | shown if network metrics are enabled |
| Application (all) | `k8s.pod.name` | shown if network metrics are enabled |
| Application (all) | `k8s.pod.start_time` | shown if network metrics are enabled |
| Application (all) | `k8s.pod.uid` | shown if network metrics are enabled |
| Application (all) | `k8s.replicaset.name` | shown if network metrics are enabled |
| Application (all) | `k8s.statefulset.name` | shown if network metrics are enabled |
| Application (all) | `k8s.cluster.name` | shown if network metrics are enabled |
| Application (all) | `k8s.daemonset.name` | shown if kubernetes metadata is enabled |

Check failure on line 53 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 53, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.deployment.name` | shown if kubernetes metadata is enabled |

Check failure on line 54 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 54, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.namespace.name` | shown if kubernetes metadata is enabled |

Check failure on line 55 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 55, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.node.name` | shown if kubernetes metadata is enabled |

Check failure on line 56 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 56, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.owner.name` | shown if kubernetes metadata is enabled |

Check failure on line 57 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 57, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.pod.name` | shown if kubernetes metadata is enabled |

Check failure on line 58 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 58, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.pod.start_time` | shown if kubernetes metadata is enabled |

Check failure on line 59 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 59, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.pod.uid` | shown if kubernetes metadata is enabled |

Check failure on line 60 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 60, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.replicaset.name` | shown if kubernetes metadata is enabled |

Check failure on line 61 in docs/sources/metrics.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. 

If the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).

If you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).

Raw Output:
{"message": "[Grafana.Spelling] Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet. To add a new word, refer to [Add words to the Grafana Labs dictionary](https://grafana.com/docs/writers-toolkit/review/lint-prose/dictionary/add-words/). Alternatively, raise an [issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%3A%20kubernetes) and a maintainer will add it for you. For UI elements, use [bold formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use [code formatting](https://grafana.com/docs/writers-toolkit/write/style-guide/style-conventions/#bold). The spell checker doesn't check words with code formatting. \n\nIf the rule is incorrect or needs improving, [report an issue](https://github.com/grafana/writers-toolkit/issues/new?title=Grafana.Spelling%20%3A%20%3CISSUE%3E).\n\nIf you have reason to diverge from the style guidance, to skip a rule, refer to [Skip rules](https://grafana.com/docs/writers-toolkit/review/lint-prose/#skip-rules).", "location": {"path": "docs/sources/metrics.md", "range": {"start": {"line": 61, "column": 76}}}, "severity": "ERROR"}
| Application (all) | `k8s.statefulset.name` | shown if kubernetes metadata is enabled |
| Application (all) | `k8s.cluster.name` | shown if kubernetes metadata is enabled |
| Application (all) | `service.name` | shown |
| Application (all) | `service.namespace` | shown |
| Application (all) | `target.instance` | shown |
Expand Down
1 change: 1 addition & 0 deletions pkg/transform/k8s.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ func (md *metadataDecorator) appendMetadata(span *request.Span, info *kube.PodIn
span.ServiceID.Metadata[attr.Name(info.Owner.LabelName)] = info.Owner.Name
topOwner := info.Owner.TopOwner()
span.ServiceID.Metadata[attr.Name(topOwner.LabelName)] = topOwner.Name
span.ServiceID.Metadata[attr.K8sOwnerName] = topOwner.Name
}
// override hostname by the Pod name
span.ServiceID.HostName = info.Name
Expand Down
2 changes: 2 additions & 0 deletions test/integration/k8s/common/k8s_metrics_testfuncs.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ func FeatureHTTPMetricsDecoration(manifest string) features.Feature {
"k8s_node_name": ".+-control-plane$",
"k8s_pod_uid": UUIDRegex,
"k8s_pod_start_time": TimeRegex,
"k8s_owner_name": "^testserver$",
"k8s_deployment_name": "^testserver$",
"k8s_replicaset_name": "^testserver-",
"k8s_cluster_name": "^beyla$",
Expand Down Expand Up @@ -163,6 +164,7 @@ func FeatureGRPCMetricsDecoration(manifest string) features.Feature {
"k8s_node_name": ".+-control-plane$",
"k8s_pod_uid": UUIDRegex,
"k8s_pod_start_time": TimeRegex,
"k8s_owner_name": "^testserver$",
"k8s_deployment_name": "^testserver$",
"k8s_replicaset_name": "^testserver-",
"k8s_cluster_name": "^beyla$",
Expand Down
1 change: 1 addition & 0 deletions test/integration/k8s/daemonset/k8s_daemonset_traces_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ func TestBasicTracing(t *testing.T) {
{Key: "k8s.node.name", Type: "string", Value: ".+-control-plane$"},
{Key: "k8s.pod.uid", Type: "string", Value: k8s.UUIDRegex},
{Key: "k8s.pod.start_time", Type: "string", Value: k8s.TimeRegex},
{Key: "k8s.owner.name", Type: "string", Value: "^otherinstance$"},
{Key: "k8s.deployment.name", Type: "string", Value: "^otherinstance$"},
{Key: "k8s.namespace.name", Type: "string", Value: "^default$"},
{Key: "k8s.cluster.name", Type: "string", Value: "^beyla$"},
Expand Down
1 change: 1 addition & 0 deletions test/integration/k8s/daemonset/k8s_daemonset_z_metrics_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ func TestProcessMetrics(t *testing.T) {
"k8s_deployment_name": "^otherinstance$",
"k8s_replicaset_name": "^otherinstance-.*",
"k8s_pod_name": "^otherinstance-.*",
"k8s_owner_name": "^otherinstance$",
}))
}

0 comments on commit 7ae8fc1

Please sign in to comment.