Skip to content

Commit

Permalink
remove client.address as default attribute on RPC metrics (#1022)
Browse files Browse the repository at this point in the history
mariomac authored Jul 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 84148fe commit 635938c
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions pkg/internal/export/attributes/attr_defs.go
Original file line number Diff line number Diff line change
@@ -236,9 +236,6 @@ func getDefinitions(groups AttrGroups) map[Section]AttrReportGroup {
attr.RPCMethod: true,
attr.RPCSystem: true,
attr.RPCGRPCStatusCode: true,
// Overriding default serverInfo configuration because we want
// to report it by default
attr.ClientAddr: true,
},
},
DBClientDuration.Section: {
2 changes: 1 addition & 1 deletion pkg/internal/pipe/instrumenter_test.go
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ func gctx(groups attributes.AttrGroups) *global.ContextInfo {
}

var allMetrics = attributes.Selection{
attributes.HTTPServerDuration.Section: attributes.InclusionLists{Include: []string{"*"}},
"*": attributes.InclusionLists{Include: []string{"*"}},
}

func allMetricsBut(patterns ...string) attributes.Selection {

0 comments on commit 635938c

Please sign in to comment.