-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: actually use wasmstan in wasmstan example #169
Conversation
WalkthroughThe changes involve updating an example implementation of the Prophet model to utilize the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)examples/forecasting/examples/prophet_wasmstan.rs (2)
The file comment and import statement accurately reflect the transition to using the WasmstanOptimizer. Also applies to: 4-4
The implementation correctly initializes the WasmstanOptimizer and integrates it with Prophet using default configurations. The simplified initialization without path parameters is an improvement over the previous CmdstanOptimizer implementation. Let's verify the example can be found and compiled: ✅ Verification successfulImplementation verified successfully The example demonstrates correct usage of WasmstanOptimizer:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the example exists and contains the correct optimizer
# Check if the example file exists and contains WasmstanOptimizer
rg -l "WasmstanOptimizer" "examples/forecasting/examples/prophet_wasmstan.rs"
# Verify there are no remaining references to CmdstanOptimizer
rg "CmdstanOptimizer" "examples/forecasting/examples/prophet_wasmstan.rs"
Length of output: 197 Script: #!/bin/bash
# Let's verify the complete implementation and dependencies
# Check the full content of the example file
cat examples/forecasting/examples/prophet_wasmstan.rs
# Check if WasmstanOptimizer is properly imported
rg -p "use.*WasmstanOptimizer" examples/forecasting/examples/prophet_wasmstan.rs
# Look for any test assertions in the file
rg -p "assert" examples/forecasting/examples/prophet_wasmstan.rs
Length of output: 2138 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
New Features
Documentation