-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otelcol.receiver.solace #2084
Conversation
972843c
to
5403698
Compare
docs/sources/reference/components/otelcol/otelcol.receiver.solace.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.solace.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.solace.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.solace.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.solace.md
Outdated
Show resolved
Hide resolved
…ace.md Co-authored-by: Clayton Cornell <[email protected]>
…ace.md Co-authored-by: Clayton Cornell <[email protected]>
That's odd, no? Any idea why did they add this? Shouldn't this be something done on the runtime level? |
Yet not a fan of this + it makes their implementation much more complex. This was done 2 years ago, maybe they wanted some extra safety because the component might be spamming a lot? They did not add any other flow control strategy since then but there is also no way around it. |
docs/sources/reference/components/otelcol/otelcol.receiver.solace.md
Outdated
Show resolved
Hide resolved
…ace.md Co-authored-by: Clayton Cornell <[email protected]>
…ace.md Co-authored-by: Piotr <[email protected]>
Co-authored-by: Piotr <[email protected]>
* Add otelcol.receiver.solace * fix test with ptr check to support empty structs * run doc generator * validate only one method of auth * Update docs/sources/reference/components/otelcol/otelcol.receiver.solace.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/reference/components/otelcol/otelcol.receiver.solace.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/reference/components/otelcol/otelcol.receiver.solace.md Co-authored-by: Clayton Cornell <[email protected]> * doc nit * Update docs/sources/reference/components/otelcol/otelcol.receiver.solace.md Co-authored-by: Piotr <[email protected]> * Update internal/component/otelcol/receiver/solace/solace.go Co-authored-by: Piotr <[email protected]> * update error msg in test --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Piotr <[email protected]>
PR Description
Add the solace receiver from the Otel contrib repo: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/solacereceiver
Which issue(s) this PR fixes
Fixes #1993
Notes to the Reviewer
A few things to note:
PR Checklist