Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label cluster_name to alloy_config_hash and some cluster_ metrics #1679

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Add label cluster_name to alloy_config_hash and some cluster_ metrics #1679

merged 6 commits into from
Sep 13, 2024

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Sep 13, 2024 •
edited
Loading

PR Description

  • I added the label "cluster_name" to the metric alloy_config_hash and removed redundant metrics logic in config_metrics.
  • I bumped the ckit version to also have the "cluster_name" label on relevant cluster_ metrics
  • I updated the clustering alerts to take the new cluster_name label into account

Which issue(s) this PR fixes

Fixes #1364

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@wildum wildum requested a review from a team as a code owner September 13, 2024 10:00
@wildum wildum changed the title Add cluster name in metric alloy_config_hash via the label alloy_cluster Add label cluster_name to alloy_config_hash and some cluster_ metrics Sep 13, 2024
mattdurham
mattdurham approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaantunes
gaantunes approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@gaantunes gaantunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gaantunes
Copy link
Contributor

This is also fixing #1365

@wildum wildum merged commit 900ff22 into main Sep 13, 2024
18 checks passed
@wildum wildum deleted the add-cluster-name-in-metrics branch September 13, 2024 14:40
@gaantunes gaantunes mentioned this pull request Sep 13, 2024
Closed
wildum added a commit that referenced this pull request Sep 13, 2024
@wildum
Add label cluster_name to alloy_config_hash and some cluster_ metrics (…
b83c8eb 
…#1679)

* Add cluster name in metric alloy_config_hash via the label alloy_cluster

* changelog entry

* bump ckit version to get cluster_name label on cluster metrics

* change label to cluster_name to be inline with ckit

* simplify config_metrics logic because empty label are ignored

* update alerts with cluster_name label
ptodev pushed a commit that referenced this pull request Sep 13, 2024
@wildum
Add label cluster_name to alloy_config_hash and some cluster_ metrics (…
957e11e 
…#1679) (#1682)

* Add cluster name in metric alloy_config_hash via the label alloy_cluster

* changelog entry

* bump ckit version to get cluster_name label on cluster metrics

* change label to cluster_name to be inline with ckit

* simplify config_metrics logic because empty label are ignored

* update alerts with cluster_name label
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaantunes gaantunes gaantunes approved these changes

@mattdurham mattdurham mattdurham approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use cluster name in alloy metrics
3 participants
@wildum @gaantunes @mattdurham