Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hpa behavior helm chart #6393

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Add hpa behavior helm chart #6393

merged 10 commits into from
Feb 20, 2024

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Feb 20, 2024

PR Description

This PR adds the HPA behavior support to the helm chart. It's useful to prevent the flagging of replica count when the metrics used for scaling up keep fluctuating. More info: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#scaling-policies

Fixes #6238

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@wildum wildum requested a review from thampiotr February 20, 2024 09:42
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests? They're in operations/helm/test

@wildum wildum force-pushed the add-hpa-behavior-helm-chart branch from 998e296 to 467636f Compare February 20, 2024 09:57
@wildum wildum requested a review from captncraig February 20, 2024 10:43
@tpaschalis
Copy link
Member

Changing the description so that it auto-closes the matching issue.

@wildum wildum merged commit 781dfe8 into main Feb 20, 2024
10 checks passed
@wildum wildum deleted the add-hpa-behavior-helm-chart branch February 20, 2024 16:16
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm - support customizing hpa behavior
4 participants