Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build info #187

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Fix build info #187

merged 1 commit into from
Sep 10, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Sep 8, 2020

After Loki support was added, it was running an init function to set build information after we ran our init function for the same purpose. This caused the build information to be misreported when running the Agent with the --version flag.

This is a temporary workaround until grafana/loki#2603 is released and vendored in the Agent.

After Loki support was added, it was running an init function to set
build information after we ran our init function for the same purpose.
This caused the build information to be misreported when running the
Agent with the --version flag.
Copy link
Member

@electron0zero electron0zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 :shipit:

@rfratto rfratto merged commit 345f24f into grafana:master Sep 10, 2020
@rfratto rfratto deleted the fix-build-info branch February 22, 2021 15:38
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
After Loki support was added, it was running an init function to set
build information after we ran our init function for the same purpose.
This caused the build information to be misreported when running the
Agent with the --version flag.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants