Skip to content

Commit

Permalink
agent-flow-mixin: fix visualization for concurrent classic and native…
Browse files Browse the repository at this point in the history
… histograms (#6607)

If both classic and native histograms are visualized concurrently, the
old query would not consistently work properly in Grafana, as the `or`
operator would return both classic and native histograms.

This would cause Grafana to visualize the histograms inconsistently,
sometimes showing nothing for time ranges where native histogram data
should be available.
  • Loading branch information
rfratto authored Mar 5, 2024
1 parent dc8d3ca commit 6fff3c3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions operations/agent-flow-mixin/dashboards/controller.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ local filename = 'agent-flow-controller.json';
panel.newQuery(
expr=|||
sum by (le) (increase(agent_component_evaluation_seconds{cluster="$cluster", namespace="$namespace"}[$__rate_interval]))
or
or ignoring (le)
sum by (le) (increase(agent_component_evaluation_seconds_bucket{cluster="$cluster", namespace="$namespace"}[$__rate_interval]))
|||,
format='heatmap',
Expand All @@ -313,7 +313,7 @@ local filename = 'agent-flow-controller.json';
panel.newQuery(
expr=|||
sum by (le) (increase(agent_component_dependencies_wait_seconds{cluster="$cluster", namespace="$namespace"}[$__rate_interval]))
or
or ignoring (le)
sum by (le) (increase(agent_component_dependencies_wait_seconds_bucket{cluster="$cluster", namespace="$namespace"}[$__rate_interval]))
|||,
format='heatmap',
Expand Down

0 comments on commit 6fff3c3

Please sign in to comment.