Tests: Add software tests and CI configuration #8
Conversation
setup.py
Outdated
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", |
There was a problem hiding this comment.
Are you comfortable with removing support for those versions of Python? In fact, it is only about the software tests, which utilize importlib.resources.files, only available on Python>=3.9.
Bringing in a backward-compatibility package, in this case importlib-resources, would not be that hard, and just a few more lines of code away.
So, just let me know if you would prefer retaining support for those.
There was a problem hiding this comment.
Not sure...
Linux Red Hat 7 python base version is still 3.6, it means that it is sill used at least in my company. In the other hand, in my old use-case, dashboards came from sandbox hosts that are in rh8 or 9 with higher version of python...
do you think it is possible to keep them ? probably with a conditionnal import
PS: Can you imagine I'm currently working on a small tool that has to be tested on RH 6 with only python 2.7!
There was a problem hiding this comment.
Thanks. I will re-add support down to Python 3.6.
There was a problem hiding this comment.
a333ab6 re-establishes compatibility of the test suite with Python 3.6.
The main code base was compatible with Python 3.6 before, and did not undergo any changes in this regard. So, this patch is exclusively about adjusting the test suite.
| ], | ||
| "test": [ | ||
| "grafana-dashboard==0.1.1", | ||
| "pydantic<2", |
There was a problem hiding this comment.
The pydantic dependency may have slipped in, and can probably be removed.
There was a problem hiding this comment.
No idea where that comes from...
Maybe I have duplicated a setup.py from an another tool without knowing what I do... (that is really possible!)
Feel free to remove it is not required.
There was a problem hiding this comment.
I think it slipped in on my updates, and the PR comment was merely a note to self. Thanks!
There was a problem hiding this comment.
I found out why it was needed: Pydantic 2.x croaks on Python 3.12, due to how it is used by grafana-dashboard.
tests/conftest.py
Outdated
| @pytest.fixture(scope="session", autouse=True) | ||
| def niquests_patch_all(): | ||
| """ | ||
| Patch module namespace, pretend Niquests is Requests. | ||
| """ | ||
| from sys import modules | ||
|
|
||
| import niquests | ||
| import urllib3 | ||
|
|
||
| # Amalgamate the module namespace to make all modules aiming | ||
| # to use `requests`, in fact use `niquests` instead. | ||
| modules["requests"] = niquests | ||
| modules["requests.adapters"] = niquests.adapters | ||
| modules["requests.sessions"] = niquests.sessions | ||
| modules["requests.exceptions"] = niquests.exceptions | ||
| modules["requests.packages.urllib3"] = urllib3 |
There was a problem hiding this comment.
It might only be a nit, but I would like to highlight such procedures better on behalf of the Niquests documentation, in order to make the road less bumpy for people writing software tests for applications or libraries which are based on Niquests.
Now, I only need to find the time. Linking it to the issue on their tracker is the best I can do for now.
/cc @Ousret
amotl
force-pushed
the
tests
branch
4 times, most recently
from
fd95121 to
0cb2462
Compare
There was a problem hiding this comment.
maybe we should replace peekjef72 by grafana-toolbox
There was a problem hiding this comment.
Thanks for spotting. I've diverted this adjustment to GH-11.
About
This patch adds a few test cases, in order to support subsequent refactorings.
Details
Contrary to previous patches, in this case, the main code base has been touched, but only at spots to improve log message formatting, and, on a single occasion, to improve exception handling and propagation.
The changes were needed to have reasonably sensible software tests without embedding too many quirks or code smells, and should also affect the implementation in a positive way, hopefully not breaking it.
References