Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and formatting #3

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Refactoring and formatting #3

merged 2 commits into from
Feb 2, 2022

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Feb 2, 2022

Hi again,

this patch renames some modules and references within the code base, in order to trim it a bit, since we introduce a breaking API change with #1 anyway. Further, it formats the code using black and isort.

With kind regards,
Andreas.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #3 (17724a7) into main (f171787) will not change coverage.
The diff coverage is 88.06%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          16       16           
  Lines         637      637           
=======================================
  Hits          547      547           
  Misses         90       90           
Impacted Files Coverage Δ
grafana_client/elements/datasource.py 34.14% <25.00%> (ø)
grafana_client/elements/user.py 30.48% <36.84%> (ø)
grafana_client/__init__.py 100.00% <100.00%> (ø)
grafana_client/api.py 100.00% <100.00%> (ø)
grafana_client/client.py 93.93% <100.00%> (ø)
grafana_client/elements/__init__.py 100.00% <100.00%> (ø)
grafana_client/elements/admin.py 100.00% <100.00%> (ø)
grafana_client/elements/annotations.py 96.42% <100.00%> (ø)
grafana_client/elements/base.py 100.00% <100.00%> (ø)
grafana_client/elements/dashboard.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f171787...17724a7. Read the comment docs.

@amotl amotl merged commit 5b68221 into main Feb 2, 2022
@amotl amotl deleted the amo/refactoring branch February 2, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants