Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding page support for search api #188

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

vbichov
Copy link
Contributor

@vbichov vbichov commented Oct 13, 2024

Description

fixes #187

Checklist

  • The patch has appropriate test coverage
  • The patch follows the style guidelines of this project
  • The patch has appropriate comments, particularly in hard-to-understand areas
  • The documentation was updated corresponding to the patch
  • I have performed a self-review of this patch

@vbichov vbichov requested a review from amotl as a code owner October 13, 2024 12:04
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (7303ec2) to head (e0818fc).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   94.44%   92.28%   -2.17%     
==========================================
  Files          26       27       +1     
  Lines        1711     1814     +103     
==========================================
+ Hits         1616     1674      +58     
- Misses         95      140      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks a stack!

@amotl amotl merged commit c6c7907 into grafana-toolbox:main Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Search" endpoint lacks page parameter
2 participants