'requireAllDefinedDependencies' computes correct scopes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
force-pushed
the
rework-requireAllDefinedDependencies
branch
2 times, most recently
from
ece874d
to
03f8b20
Compare
Before the 'transitive' scope was not correct (see removed comment in code). This let to different results depending for components that were direct and transitive dependencies.
jjohannes
force-pushed
the
rework-requireAllDefinedDependencies
branch
from
03f8b20
to
2d5d0da
Compare
jjohannes
force-pushed
the
rework-requireAllDefinedDependencies
branch
from
62ee830
to
5985cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the 'transitive' scope was not correct (see removed comment in code). This let to different results depending for components that were direct and transitive dependencies.
Follow up to #81