Action causes '[DEP0005] DeprecationWarning'

[dmurat]

For all steps using gradle-command-action I'm getting deprecation warning: [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

Is this expected or should it be fixed?

Tnx

[dmurat]

If needed, here is a sample workflow: https://github.com/croz-ltd/klokwrk-project/actions/runs/140909371

[eskatos]

Thanks for the report @dmurat.

This deprecation warning is coming from a dependency of the action. I still have to figure out which one.
It isn't a problem per se but that warning will go away when upgrading the offending dependency to a fixed version once available.
I just tried upgrading all outdated dependencies and the deprecation message is still present, I'll get back to this regularly.

[marracuene]

Also getting this warning - and it seems to have the ability to intermittently crash the gradle process.

If you look at runs #9 and #10 of this action, you will see that #9 gave this warning and then appeared to fail because of it. See line 2020-06-23T19:26:06.3961561Z ##[error]Premature close

Whereas #10 (which differs only in the indenting of a comment line - which I used to trigger a new run) did not give this warning, and proceeded with the build.

N.B. this repo is a clone of https://github.com/gradle/playframework, which I forked purely in order to investigate mysterious build failures which I cannot reproduce locally. The failures only occur in a CI environment. See: gradle/playframework#136

[bshaffer]

Our builds are also failing due to this error, and it does not seem to be intermittent.

[eskatos]

Hum, thanks all for the reports! I'll investigate.
In the meantime you can pin your action usage to v1.2.0 that didn't have this problem.

[marracuene]

In the meantime you can pin your action usage to v1.2.0 that didn't have this problem.

Hmm. Pinning to v1.2.0 didn't actually fix it. Which suggests that something more fundamental is at play.
See here
... specifically the bit where it says:

Run eskatos/[email protected]
(node:2754) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Cache Size: ~193 MB (202061936 B)

[eskatos]

I tracked this down to microsoft/typed-rest-client.
This has been fixed upstream microsoft/typed-rest-client@de7bcee but not released yet.

I suppose it could be replaced by e.g. https://github.com/actions/http-client
Nope, same problem ...

[nuhkoca]

Any update on this?

[amotl]

Hi there,

I tracked this down to microsoft/typed-rest-client.

microsoft/typed-rest-client@5f16b0dc might have fixed this, so I humbly asked for a new release at microsoft/typed-rest-client#246.

With kind regards,
Andreas.

[amotl]

Hi again,

@damccorm was so kind to publish typed-rest-client 1.8.1 right away [1]. Thank you!

With kind regards,
Andreas.

[1] https://www.npmjs.com/package/typed-rest-client

[bigdaz]

This was fixed in v1.4.0