Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples capturing maxParallelForks as a custom value #909

Merged

Conversation

tylerbertrand
Copy link
Member

@tylerbertrand tylerbertrand commented Oct 12, 2023

Applying Groovy sample as a script plugin... custom values
Applying Kotlin sample as a script plugin... custom values

Groovy sample is configuration cache compatible
Kotlin sample is configuration cache compatible

Copy link
Member

@erichaagdev erichaagdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions.

Copy link
Member

@erichaagdev erichaagdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@erichaagdev erichaagdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tylerbertrand tylerbertrand merged commit 6b507f5 into main Oct 13, 2023
@tylerbertrand tylerbertrand deleted the tylerbertrand/gradle-maxparallelforks-data-capture-sample branch October 13, 2023 19:47
@@ -0,0 +1,10 @@
def buildScan = project.extensions.findByName('buildScan')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this check in the kotlin version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants