Migrated a gradle groovy sample to develocity plugin api #1331
Conversation
| @@ -12,7 +12,7 @@ import java.util.stream.Collectors | |||
| * adding a flag as custom value. | |||
| */ | |||
|
|
|||
| def buildScanApi = project.extensions.findByName('buildScan') | |||
| def buildScanApi = project.extensions.findByName('develocity').getBuildScan(); | |||
There was a problem hiding this comment.
This is different than how we do it in all other samples.
I believe this will throw a NPE if the develocity extension doesn't exist, though it's unlikely you would be applying this with the Develocity Gradle plugin applied.
There was a problem hiding this comment.
Yes, I know it's different, but I'm not sure how to do it differently in groovy, as doing what was there before get's you an error: Could not find matching constructor for: Capture(com.gradle.enterprise.gradleplugin.internal.extension.b_Decorated, org.gradle.internal.logging.slf4j.OutputEventListenerBackedLogger) - scan. I'll handle the develocity being null though, missed that.
There was a problem hiding this comment.
I see you pushed some changes. Does it fix the error you're describing?
There was a problem hiding this comment.
Nope, it just fixes the case where develocity extension is not available
There was a problem hiding this comment.
Okay so the script is still broken?
There was a problem hiding this comment.
No, the way I opened the PR is not broken - I wouldn't open a PR otherwise (it also shouldn't pass the tests if it were broken) :)
There was a problem hiding this comment.
Okay, I misunderstood what you said earlier.
Migrated a missed gradle groovy sample to develocity plugin api