-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention sample for single build Gradle plugin and Maven extension is added #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
force-pushed
the
erichaagdev/convention-develocity-shared
branch
from
July 29, 2024 15:44
d27b9e0
to
f4e7a9c
Compare
erichaagdev
changed the title
Single build Gradle plugin and Maven extension convention sample is added
Convention sample for single build Gradle plugin and Maven extension is added
Jul 29, 2024
erichaagdev
force-pushed
the
erichaagdev/convention-develocity-shared
branch
16 times, most recently
from
July 30, 2024 18:46
d991382
to
a3e275a
Compare
clayburn
reviewed
Jul 30, 2024
.github/workflows/convention-develocity-maven-extension-verification.yml
Outdated
Show resolved
Hide resolved
.github/workflows/convention-develocity-shared-verification.yml
Outdated
Show resolved
Hide resolved
jprinet
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Eric, all clear!
I left a comment with a fancy idea to try to ease consumption of the lib. Not sure that would help a lot though.
...ocity-shared/convention-develocity-shared/src/main/java/com/myorg/DevelocityConventions.java
Outdated
Show resolved
Hide resolved
erichaagdev
force-pushed
the
erichaagdev/convention-develocity-shared
branch
2 times, most recently
from
August 2, 2024 18:10
1da2910
to
74d54ff
Compare
clayburn
approved these changes
Aug 2, 2024
erichaagdev
force-pushed
the
erichaagdev/convention-develocity-shared
branch
from
August 12, 2024 20:05
407978a
to
820acb5
Compare
erichaagdev
force-pushed
the
erichaagdev/convention-develocity-shared
branch
from
August 12, 2024 20:10
820acb5
to
f8468ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a working sample of a single build containing both a Convention Develocity Gradle plugin & Convention Develocity Maven extension, where common Develocity configuration is shared between the two.
The sample should feel very similar to the existing Convention Develocity Gradle plugin and Convention Develocity Maven extension that exist already in this repository.
The structure of the sample is as follows (also visible in the README of the sample):
convention-develocity-gradle-plugin
- Contains the convention Gradle pluginconvention-develocity-maven-extension
- Contains the convention Maven extensionconvention-develocity-shared
- Contains the convention logic shared between build toolsexamples
- Contains example builds that apply the convention Gradle plugin or Maven extension for different Gradle and Maven versionsgradle_5
- Applies the convention Gradle plugin on a Gradle 5 buildgradle_6
- Applies the convention Gradle plugin on a Gradle 6 buildgradle_6.9_and_later
- Applies the convention Gradle plugin on a Gradle 6.9 and later buildmaven_3
- Applies the convention Maven extension on a Maven 3 buildTesting
Just as was added for the other convention samples, a GitHub Actions workflow has been added that publishes the conventions locally and runs the example builds. The workflow tests both the Gradle and Maven conventions.
Deviations
Everything in this PR matches what was proposed in the specification, except for shadowing
convention-develocity-shared
inconvention-develocity-gradle-plugin
andconvention-develocity-maven-extension
. While possible, this added a lot of additional build logic that I felt detracted from the point of the sample. As this is only a sample, shadowing all components to a single jar can still be done if desired by the user (as could be done for the other samples too).