-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention Develocity Gradle plugin configures Develocity Gradle plugin #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
commented
May 15, 2024
...ugin/plugins/gradle-5-or-newer/src/main/java/com/myorg/ConventionDevelocityGradlePlugin.java
Outdated
Show resolved
Hide resolved
...ugin/plugins/gradle-5-or-newer/src/main/java/com/myorg/ConventionDevelocityGradlePlugin.java
Show resolved
Hide resolved
clayburn
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
erichaagdev
force-pushed
the
erichaagdev/convention-gradle-plugin-dv
branch
8 times, most recently
from
May 16, 2024 21:19
f46d49f
to
4e67808
Compare
erichaagdev
commented
May 16, 2024
.github/workflows/convention-develocity-gradle-plugin-verification.yml
Outdated
Show resolved
Hide resolved
clayburn
reviewed
May 17, 2024
erichaagdev
force-pushed
the
erichaagdev/convention-gradle-plugin-dv
branch
from
June 20, 2024 14:31
f886823
to
5037ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Convention Develocity Gradle plugin sample to configure the Develocity Gradle plugin.
Additionally, a verification workflow has been added to ensure everything works as expected. https://github.com/gradle/develocity-build-config-samples/actions/workflows/convention-develocity-gradle-plugin-verification.yml
Resolves gradle/dv#34435