Add dependency checksums to quarkus caching extension #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @aloubyansky @gsmet |
aloubyansky
reviewed
Feb 29, 2024
| A key component of the caching mechanism is the Quarkus configuration dump file `.quarkus/quarkus-prod-config-dump`. | ||
| This file is generated by the Quarkus `build` goal when the Maven property `quarkus.config-tracking.enabled` is `true`. | ||
| It contains all the Quarkus properties used during the Quarkus `build` process. | ||
| Some properties are discovered late in the `build` phase and can't be determined advance, thus the need for a first full execution to generate the file. |
There was a problem hiding this comment.
Suggested change
| Some properties are discovered late in the `build` phase and can't be determined advance, thus the need for a first full execution to generate the file. | |
| Some properties are discovered late in the `build` phase and can't be determined in advance, thus the need for a first full execution to generate the file. |
runningcode
reviewed
Mar 1, 2024
| The file `.quarkus/quarkus-prod-config-dump` generated by the Quarkus build `goal` must be present to allow a cache hit. | ||
|
|
||
| In order to increase the cache hit rate, it is possible to check-in the file in the source code repository. | ||
| in continuous integration environment, an alternative is to have a cache restoring the file. |
There was a problem hiding this comment.
an alternative is to have a cache restoring the file.
The word cache here can be misleading. I assume you mean some sort of CI store/restore functionality? Not the build cache?
There was a problem hiding this comment.
Correct, I'll update with
in continuous integration environment, an alternative is to have the file restored (see this option for GitHub actions as an example).
| => The `build` goal is not cacheable | ||
| - `build` executes and creates `.quarkus/quarkus-prod-config-dump` | ||
|
|
||
|  |
There was a problem hiding this comment.
nice to add these diagrams!
quarkus-build-caching-extension/src/main/java/com/gradle/QuarkusExtensionConfiguration.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nelson Osacky <[email protected]> Signed-off-by: Jérôme Prinet <[email protected]>
Co-authored-by: Nelson Osacky <[email protected]> Signed-off-by: Jérôme Prinet <[email protected]>
runningcode
approved these changes
Mar 4, 2024
jprinet
deleted the
jprinet/add-dependency-checksums-to-quarkus-caching-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This change is the last one before v1.0.
The Quarkus Maven plugin dynamically adds some dependencies to the
classpath, which must be declared as additional inputs.This change on Quarkus enables the creation of a file containing this list of dependencies.
This file is the one to add as goal input.
This dynamic
classpathchange is also happening for the tests (surefire/failsafe), and this PR takes care of adding the extra input based on a propertyaddQuarkusInputs.Changes
buildandtestgoals