Fix short lived access token query (#59)

* Fix develocity-token-expiry configuration * Fix vulnerability in path-to-regexp
gradle · Sep 13, 2024 · 6f6f51c · 6f6f51c
1 parent 02ca668
commit 6f6f51c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/build-scan-shared/src/auth/short-lived-token.ts b/build-scan-shared/src/auth/short-lived-token.ts
@@ -78,7 +78,7 @@ class ShortLivedTokenClient {
     retryInterval = 1000
 
     async fetchToken(serverUrl: string, accessKey: HostnameAccessKey, expiry: string): Promise<HostnameAccessKey> {
-        const queryParams = expiry ? `?expiresInHours${expiry}` : ''
+        const queryParams = expiry ? `?expiresInHours=${expiry}` : ''
         const sanitizedServerUrl = !serverUrl.endsWith('/') ? `${serverUrl}/` : serverUrl
         const headers = {
             'Content-Type': 'application/json',

diff --git a/dist/maven-publish-build-scan/index.js b/dist/maven-publish-build-scan/index.js
@@ -134475,7 +134475,7 @@ class ShortLivedTokenClient {
     maxRetries = 3;
     retryInterval = 1000;
     async fetchToken(serverUrl, accessKey, expiry) {
-        const queryParams = expiry ? `?expiresInHours${expiry}` : '';
+        const queryParams = expiry ? `?expiresInHours=${expiry}` : '';
         const sanitizedServerUrl = !serverUrl.endsWith('/') ? `${serverUrl}/` : serverUrl;
         const headers = {
             'Content-Type': 'application/json',

diff --git a/dist/maven-setup/main/index.js b/dist/maven-setup/main/index.js
@@ -41095,7 +41095,7 @@ class ShortLivedTokenClient {
     maxRetries = 3;
     retryInterval = 1000;
     async fetchToken(serverUrl, accessKey, expiry) {
-        const queryParams = expiry ? `?expiresInHours${expiry}` : '';
+        const queryParams = expiry ? `?expiresInHours=${expiry}` : '';
         const sanitizedServerUrl = !serverUrl.endsWith('/') ? `${serverUrl}/` : serverUrl;
         const headers = {
             'Content-Type': 'application/json',

diff --git a/dist/maven-setup/post/index.js b/dist/maven-setup/post/index.js
@@ -134475,7 +134475,7 @@ class ShortLivedTokenClient {
     maxRetries = 3;
     retryInterval = 1000;
     async fetchToken(serverUrl, accessKey, expiry) {
-        const queryParams = expiry ? `?expiresInHours${expiry}` : '';
+        const queryParams = expiry ? `?expiresInHours=${expiry}` : '';
         const sanitizedServerUrl = !serverUrl.endsWith('/') ? `${serverUrl}/` : serverUrl;
         const headers = {
             'Content-Type': 'application/json',

diff --git a/package-lock.json b/package-lock.json
diff --git a/release/changelog.md b/release/changelog.md
@@ -0,0 +1 @@
+- Fixes a bug where setting the develocity-token-expiry parameter had no effect
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Fixes a bug where setting the develocity-token-expiry parameter had no effect