Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fetch new versions when validating wrapper jars #171

Closed
bigdaz opened this issue Apr 13, 2024 · 0 comments · Fixed by #292
Closed

Only fetch new versions when validating wrapper jars #171

bigdaz opened this issue Apr 13, 2024 · 0 comments · Fixed by #292
Assignees
@bigdaz
Labels
enhancement New feature or request in:wrapper-validation
Milestone
v4.0.0

Comments

@bigdaz
Copy link
Member

bigdaz commented Apr 13, 2024

Currently, if a wrapper checksum isn't in the "known" list we then fetch the checksums for all Gradle versions (even those that are in the "known" list).
Instead, we should only fetch checksums for versions that are not in the known checksums list.
@bigdaz bigdaz added enhancement New feature or request in:wrapper-validation labels Apr 13, 2024
@bigdaz bigdaz mentioned this issue Apr 15, 2024
Closed
@bigdaz bigdaz self-assigned this Jul 15, 2024
bigdaz added a commit that referenced this issue Jul 15, 2024
@bigdaz
Only fetch checksums for unknown wrapper versions
40aa6a0 
The checksum values for most wrapper versions are hard-coded into the action.
These known checksum values are first used for validation: only if none of the known
values work do we download checksums.

Previously, we blindly downloaded all of the checksum values in this case: we now only
download the checksums for versions that are not in our "known" set.

Fixes #171
@bigdaz bigdaz mentioned this issue Jul 15, 2024
Merged
@bigdaz bigdaz closed this as completed in dff3ef9 Jul 16, 2024
@bigdaz bigdaz modified the milestones: v3.6.0, v4.0.0 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigdaz bigdaz

Labels
enhancement New feature or request in:wrapper-validation
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Only fetch checksums for unknown wrapper versions gradle/actions
1 participant
@bigdaz