Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the Tool accordion is closed if it is not the last message #9826

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

freddyaboulton
Copy link
Collaborator

Description

Closes #9776

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 24, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/7a0d06885ca88b35bc4fbd6dacfedb4fc06c2b0b/gradio-5.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@7a0d06885ca88b35bc4fbd6dacfedb4fc06c2b0b#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/7a0d06885ca88b35bc4fbd6dacfedb4fc06c2b0b/gradio-client-1.7.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/7a0d06885ca88b35bc4fbd6dacfedb4fc06c2b0b/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 24, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Make sure the Tool accordion is closed if it is not the last message

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton added v: patch A change that requires a patch release t: fix A change that implements a fix labels Oct 24, 2024
@freddyaboulton freddyaboulton marked this pull request as ready for review October 24, 2024 01:02
@pngwn
Copy link
Member

pngwn commented Oct 28, 2024

Did AI write the PR title or are you just drunk?

@freddyaboulton freddyaboulton changed the title Make sure Tool accordion closed if now the last assistant message Make sure the Tool accordion is closed if it is not the last message Oct 30, 2024
@freddyaboulton
Copy link
Collaborator Author

@pngwn 😂

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @freddyaboulton, code looks good!
I think the open state should also be configurable via metadata, I agree with #9776 (comment), something like gr.Accordion e.g.

ChatMessage(
            role="assistant",
            content="...",
            metadata={"title": "...", open=True},
        )

I could see users wanting to always hide logic when its verbose, or always have it visible.

@freddyaboulton
Copy link
Collaborator Author

Thanks @aliabid94 ! yea that's reasonable - I'll open a separate PR for that!

@freddyaboulton freddyaboulton merged commit 69acfeb into main Oct 31, 2024
23 of 24 checks passed
@freddyaboulton freddyaboulton deleted the fix-tool-message branch October 31, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to display chat messages accordion closed by default for assistant message
4 participants