Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Optimize /file route #7416

Merged
merged 6 commits into from
Feb 15, 2024
Merged

WIP: Optimize /file route #7416

merged 6 commits into from
Feb 15, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Feb 14, 2024

Description

Current /file route will scan over all the temp file sets to check if the file is allowed. This can cause latency in demos that create a lot of files across components, e.g. stable cascade (context). Solution here is to finish the scan early as soon as we find a match.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 14, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/dc1429c0a4d165bc14d686730424a9aea4e3762a/gradio-4.19.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@dc1429c0a4d165bc14d686730424a9aea4e3762a#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 14, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

WIP: Optimize /file route

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton
Copy link
Collaborator Author

freddyaboulton commented Feb 15, 2024

Looks like this is helping the stablecascade demo so going to open for review. Seems like a reasonable change to make regardless though.

@freddyaboulton freddyaboulton marked this pull request as ready for review February 15, 2024 20:31
@abidlabs
Copy link
Member

Thanks @freddyaboulton for the fix. Makes sense, with tens of thousands of files, the union operator is linear in the number of files, while this solution should be linear in the number of blocks (which is fixed and small), while the look ups themselves are constant time.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Feb 15, 2024
@freddyaboulton freddyaboulton enabled auto-merge (squash) February 15, 2024 21:43
@freddyaboulton freddyaboulton merged commit c88290d into main Feb 15, 2024
7 checks passed
@freddyaboulton freddyaboulton deleted the run-file-in-threadpool branch February 15, 2024 21:50
@pngwn pngwn mentioned this pull request Feb 15, 2024
@freddyaboulton
Copy link
Collaborator Author

Thanks for the review @abidlabs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants