-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Optimize /file route #7416
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/dc1429c0a4d165bc14d686730424a9aea4e3762a/gradio-4.19.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@dc1429c0a4d165bc14d686730424a9aea4e3762a#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Looks like this is helping the stablecascade demo so going to open for review. Seems like a reasonable change to make regardless though. |
Thanks @freddyaboulton for the fix. Makes sense, with tens of thousands of files, the union operator is linear in the number of files, while this solution should be linear in the number of blocks (which is fixed and small), while the look ups themselves are constant time. |
Thanks for the review @abidlabs ! |
Description
Current
/file
route will scan over all the temp file sets to check if the file is allowed. This can cause latency in demos that create a lot of files across components, e.g. stable cascade (context). Solution here is to finish the scan early as soon as we find a match.🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh