Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy_discord to docs #5076

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Add deploy_discord to docs #5076

merged 5 commits into from
Aug 3, 2023

Conversation

freddyaboulton
Copy link
Collaborator

Description

Oversight on my part from #4960

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Aug 3, 2023 5:02pm

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 2, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
gradio_client minor
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add deploy_discord to docs

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 2, 2023

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-5076-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/50aa6e97316fa707487524779561b362a59ae266/gradio-3.39.0-py3-none-any.whl

@freddyaboulton freddyaboulton added the docs/website Related to documentation or website label Aug 2, 2023
@freddyaboulton
Copy link
Collaborator Author

@aliabd Why doesn't it show up in the vercel preview?

@freddyaboulton freddyaboulton marked this pull request as ready for review August 2, 2023 21:15
@aliabd
Copy link
Collaborator

aliabd commented Aug 2, 2023

run python generate_jsons/generate.py from inside js/_website and commit the json files. But make sure you have an editable pip install of gradio and gradio_client

@aliabd
Copy link
Collaborator

aliabd commented Aug 2, 2023

(hopefully this will be much easier soon)

Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @freddyaboulton! I updated the jsons so it shows up in preview. Will merge

@aliabd aliabd merged commit 2745075 into main Aug 3, 2023
@aliabd aliabd deleted the deploy-discord-docs branch August 3, 2023 17:07
@pngwn pngwn mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/website Related to documentation or website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants