JS Client: Fixes cannot read properties of null (reading 'is_file') #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_file doesn't exist on d. Therefore invoking d.is_file will error out. This commit fixes that by failing quietly if the is_file property doesn't exist on d.
fixed spacing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Hi @raymondtri thanks for the contribution. Can you give a quick code example of where you're seeing this issue? |
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-5035-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/0e97ff844776dd6a99d0f31aeffb775bf0564583/gradio-3.39.0-py3-none-any.whl |
|
Hi @raymondtri just to follow up, can you share an example of what issue this PR is fixing? |
|
Will go ahead and merge this in. Though would still be good to know what triggered this error! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In transform_output, typeof d can be an object even if the property is_file doesn't exist on d. Therefore attempting to access d.is_file will error out. This commit fixes that by failing quietly if the is_file property doesn't exist on d.
Closes: (no issue, the fix is very small)
🎯 PRs Should Target Issues
The fix is very small.