Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure tags aren't rendered inside a guide #5007

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jul 24, 2023

Tags are getting rendered inside a guide, this fixes that. Also cleans up some small markdown issues / broken links with a few guides.

Closes this from #4804:

  • tags should be filtered out of guides

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Jul 24, 2023 8:50pm

@aliabd aliabd self-assigned this Jul 24, 2023
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 24, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Make sure tags aren't rendered inside a guide

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 24, 2023

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-5007-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/3e70fc81fc12dcb07f40a280b972a61348c9d263/gradio-3.38.0-py3-none-any.whl

@aliabd aliabd changed the title Remove tags from rendering inside a guide and small fixes Make sure tags aren't rendered inside a guide Jul 24, 2023
@aliabd aliabd added the t: fix A change that implements a fix label Jul 24, 2023
@aliabd aliabd added the v: patch A change that requires a patch release label Jul 24, 2023
@aliabd aliabd merged commit 71c9039 into main Jul 24, 2023
@aliabd aliabd deleted the aliabd/remove-tags branch July 24, 2023 20:54
@pngwn pngwn mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants