Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove website jsons from git and add script to pnpm build #4953

Closed
wants to merge 35 commits into from

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jul 18, 2023

This PR removes the annoying website jsons from git and adds the generation script to the pnpm command. That way you don't have to run the script anymore or commit jsons. I also overrid the vercel build command to run pnpm build instead of vite build.

Closes this in #4804:

  • Stop tracking jsons in git

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Jul 24, 2023 3:33pm

@aliabd aliabd requested a review from pngwn July 18, 2023 00:30
@aliabd aliabd marked this pull request as draft July 18, 2023 00:30
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 18, 2023

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4953-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/4b0e98e40ac94b8c43ba2158d02ec0ce27366881/gradio-3.38.0-py3-none-any.whl

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 18, 2023

🎉 Chromatic build completed!

There are 0 visual changes to review.
There are 0 failed tests to fix.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 24, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Remove website jsons from git and add script to pnpm build

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants