Fix loading spaces with api_name=False #4886
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4886-all-demos |
freddyaboulton
added
the
no-visual-update
|
Chromatic build successful 🎉 |
…o fix-bool-false-api
| @@ -550,7 +550,7 @@ def _infer_fn_index(self, api_name: str | None, fn_index: int | None) -> int: | |||
| if api_name is not None: | |||
| for i, d in enumerate(self.config["dependencies"]): | |||
| config_api_name = d.get("api_name") | |||
| if config_api_name is None: | |||
| if config_api_name is None or config_api_name is False: | |||
There was a problem hiding this comment.
Not writing as if not config_api_name cause the api_name can theoretically be "" which evaluates to false.
There was a problem hiding this comment.
@freddyaboulton
Hmm, but I think api_name='' should be considered invalid.
Looks like use via API page becomes weird when it has a method with api_name=''.
In the case of the Space used for testing this PR, the API page is empty.
Also, if a Space has only one method and whose api_name is '', then the API page will become like this:
Though it says there's one endpoint, but no API was shown.
I think we should change to make empty API name invalid (in another PR?).
There was a problem hiding this comment.
FYI, I opened a new issue for this weird behavior of API page. #4894
There was a problem hiding this comment.
Yea we can solve that issue in a separate PR!
|
Nice! Code looks good + can confirm that the original issue has been fixed. |
Description
Closes #4884
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.shUnless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.mdfile and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".