-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output directory of files in client & when calling Blocks as function #4501
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4501-all-demos |
@abidlabs is this ready? Got tagged for review but it's still a draft. Quick turnaround! |
Just adding tests @freddyaboulton! Will open up soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @abidlabs !
Thanks @freddyaboulton for the review! Will address the suggestions tomorrow |
I'll need to release a new version of |
Previously, different serializers saved output files in inconsistent places. This meant that if you used the client to do a prediction, it could save output files in various places -- including the working directory for the
Gallery
component (see #4494). This fixes that -- all of the serializers save output files to a folder created within theGRADIO_TEMP_DIR
directory.Test with:
and so on.
Furthermore, if you are using the python
Client
, you can specify the output directory with a newoutput_dir
parameter.Closes: #4494
Closes: #4495