-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix view_api bug where unnamed rotes where showing api_name instead of fn_index #3972
Fix view_api bug where unnamed rotes where showing api_name instead of fn_index #3972
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3972-all-demos |
client/python/test/test_client.py
Outdated
|
||
Unnamed API endpoints: 1 | ||
|
||
- predict(parameter1, fn_index=0) -> value2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion, maybe just check if "fn_index=0"
is in the string, as the format of the view_api(return_format="str")
may change and we don't want this test to be welded too tightly to the format
(this would also fix the failing test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed now @abidlabs ! Thanks
4d0829b
to
e9de30e
Compare
Thanks @freddyaboulton for the fix! |
Description
Long-winded title but the issue was that unnamed routes were shown with
api_name='0'
as opposed tofn_index=0
, which caused user confusion.Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.