Support gr.Progress() in python client #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3924-all-demos |
freddyaboulton
requested review from
aliabid94,
abidlabs,
aliabd,
dawoodkhan82,
pngwn and
AK391
and removed request for
aliabid94
abidlabs
reviewed
Apr 24, 2023
client/python/test/test_client.py
Outdated
| statuses.append(job.status()) | ||
| time.sleep(0.05) | ||
| assert any(s.code == Status.PROGRESS for s in statuses) | ||
| assert any(s.progress_data is not None for s in statuses) |
There was a problem hiding this comment.
Nit: can we make this test more speicific? E.g. assert something like the
any(s.progress_data == ProgressUnit(index=19, length=20, unit="steps", progress=None, desc=None) for s in statuses)
It will help readers of the codebase understand the expected format of the progress data
|
Nice fix @freddyaboulton! This LGTM. I would just add some more documentation around the And I would add a test for a difference Space which doesn't have a progress bar, asserting that the |
abidlabs
approved these changes
Apr 24, 2023
freddyaboulton
force-pushed
the
fix-progress-tracking-for-client
branch
from
23ab7e2
to
5f61548
Compare
|
Thanks for the review and helpful comments @abidlabs ! Pushed both of those changes up and will fix after CI |
freddyaboulton
force-pushed
the
fix-progress-tracking-for-client
branch
from
ae70d16
to
a11af11
Compare
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug where progress updates via gr.Progress were causing the client to crash. This PR adds the correct parsing to the progress messages so that they can be accessed via
job.status().progress_dataChecklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.