Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes chatbot autoscroll + Textbox lines > 20 issue #3637

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Fixes chatbot autoscroll + Textbox lines > 20 issue #3637

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b40c0b
fixes
dawoodkhan82 Mar 27, 2023
8fdcfbb
changelog
dawoodkhan82 Mar 27, 2023
1628901
Merge branch 'main' into fixes
abidlabs Mar 27, 2023
59c19ae
Update gradio/components.py
dawoodkhan82 Mar 27, 2023
e15b8fa
Merge branch 'main' into fixes
dawoodkhan82 Mar 27, 2023
b5031e6
Update CHANGELOG.md
dawoodkhan82 Mar 27, 2023
a5aebbf
Update CHANGELOG.md
dawoodkhan82 Mar 27, 2023
7d0d39b
Merge branch 'main' into fixes
dawoodkhan82 Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
- Fixes `Chatbot` and `Image` components so that files passed during processing are added to a directory where they can be served from, by [@abidlabs](https://github.com/abidlabs) in [PR 3523](https://github.com/gradio-app/gradio/pull/3523)
- Use Gradio API server to send telemetry using `huggingface_hub` [@dawoodkhan82](https://github.com/dawoodkhan82) in [PR 3488](https://github.com/gradio-app/gradio/pull/3488)
- Fixes an an issue where if the Blocks scope was not exited, then State could be shared across sessions, by [@abidlabs](https://github.com/abidlabs) in [PR 3600](https://github.com/gradio-app/gradio/pull/3600)
- Fixed bug where "or" was not being localized in file upload text by [@freddyaboulton](https://github.com/freddyaboulton) in [PR 3599](https://github.com/gradio-app/gradio/pull/3599)
- Fixed bug where "or" was not being localized in file upload text by [@freddyaboulton](https://github.com/freddyaboulton) in [PR 3599](https://github.com/gradio-app/gradio/pull/3599)
- Fixed bug where chatbot does not autoscroll inside of a tab, row or column by [@dawoodkhan82](https://github.com/dawoodkhan82) in [PR ](https://github.com/gradio-app/gradio/pull/)
- Fixed bug where textbox shrinks when `lines` set to larger than 20 by [@dawoodkhan82](https://github.com/dawoodkhan82) in [PR ](https://github.com/gradio-app/gradio/pull/)

## Documentation Changes:

Expand Down
5 changes: 4 additions & 1 deletion gradio/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,10 @@ def __init__(

#
self.lines = lines
self.max_lines = max_lines if type == "text" else 1
if type == "text":
self.max_lines = lines if lines > max_lines else max_lines
dawoodkhan82 marked this conversation as resolved.
Show resolved Hide resolved
else:
self.max_lines = 1
self.placeholder = placeholder
self.select: EventListenerMethod
"""
Expand Down
2 changes: 1 addition & 1 deletion ui/packages/chatbot/src/ChatBot.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

beforeUpdate(() => {
autoscroll =
div && div.offsetHeight + div.scrollTop > div.scrollHeight - 20;
div && div.offsetHeight + div.scrollTop > div.scrollHeight - 100;
});

afterUpdate(() => {
Expand Down