Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining blockers for Python client #3565

Closed
18 of 19 tasks
abidlabs opened this issue Mar 21, 2023 · 11 comments
Closed
18 of 19 tasks

Remaining blockers for Python client #3565

abidlabs opened this issue Mar 21, 2023 · 11 comments
Assignees
Labels
gradio_client Related to the one of the gradio client libraries
Milestone

Comments

@abidlabs
Copy link
Member

abidlabs commented Mar 21, 2023

From #3300, here are the remaining TODOs for the Gradio Python client:

Necessary

  • add a changelog for the client library -- @abidlabs
  • add to view API page -- @aliabd
  • Files should be uploaded via /upload -- @freddyaboulton
  • Add a Guide for using the python client -- @abidlabs & @aliabd
  • rate limit public Spaces, and display a meaningful error when rate limited (ideally saying something like you can duplicate this Space and make it private to avoid being rate limited)
  • add documentation for this on the website (@aliabd)
  • add support for iterators -- right now iterators return a meaningless update as a result @freddyaboulton
  • add a way to get the status of a job @freddyaboulton
  • add ability to inspect and quick get an idea of how to use each of the API endpoints for a given gradio app, including unnamed endpoints
  • add more tests @freddyaboulton
  • add to the changelog
  • clarify that callbacks are executed sequentially
  • Session management / a method to reset session
  • add new version release GH action
  • add analytics
  • Document that the HF token is pulled if you are logged in via HF CLI
  • __repr__ returns error
  • Support passing in images as numpy arrays / pil images (note: I don't think we should do this in the client)
  • Paths to files / images are confusing. Can we display them instead?
  • "/predict" instead of "predict"
  • we shouldn't assume fn_index=0
@abidlabs abidlabs self-assigned this Mar 21, 2023
@abidlabs abidlabs added the gradio_client Related to the one of the gradio client libraries label Mar 21, 2023
@abidlabs abidlabs added this to the 3.x milestone Mar 24, 2023
@freddyaboulton
Copy link
Collaborator

Added my name to some of the tasks @abidlabs

@abidlabs
Copy link
Member Author

Thank you so much @freddyaboulton!

@freddyaboulton
Copy link
Collaborator

We should add a CHANGELOG for the clients, no?

@abidlabs
Copy link
Member Author

👍 sounds good, added to the list

@pngwn
Copy link
Member

pngwn commented Mar 28, 2023

@freddyaboulton
Copy link
Collaborator

I think upload limits should be set at the app level and not the client level. Right now the app doesn't set upload limits (not saying that's a good idea) but it'd be weird if there was that inconsistency between the client and app.

@freddyaboulton
Copy link
Collaborator

@abidlabs Is support for spaces with auth on the roadmap?

@abidlabs
Copy link
Member Author

Yes let's create a separate issue for that and the other nice-to-haves because they are not blockers to launch (I can create the issues)

@abidlabs abidlabs changed the title Remaining todos for Python client Remaining blockers for Python client Apr 10, 2023
@abidlabs
Copy link
Member Author

Renamed so that this issue is only focused on the blockers

@abidlabs
Copy link
Member Author

Everything except rate limiting is complete, congrats everyone 🥳

Will close since rate limiting is a moon-landing issue, not a gradio issue

@justinzyw
Copy link

@abidlabs Is support for spaces with auth on the roadmap?

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradio_client Related to the one of the gradio client libraries
Projects
None yet
Development

No branches or pull requests

5 participants